PHP 8.4 support

chrome-php · Nov 6, 2024 · d30d4df · d30d4df
1 parent 5b9a4d8
commit d30d4df
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 6 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -11,7 +11,7 @@ jobs:
 
     strategy:
       matrix:
-        php: ['7.4', '8.0', '8.1', '8.2', '8.3']
+        php: ['7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
 
     steps:
       - name: Checkout Code

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,11 @@
 # CHANGELOG
 
 
+## 1.6.1 (UPCOMING)
+
+* Add support for PHP 8.4
+
+
 ## 1.6.0 (2024-03-17)
 
 * Add support for PHP 8.3

diff --git a/src/Connection.php b/src/Connection.php
@@ -246,7 +246,7 @@ public function getClientApplication()
      *
      * @return bool
      */
-    public function close(int $code = Protocol::CLOSE_NORMAL, string $reason = null): bool
+    public function close(int $code = Protocol::CLOSE_NORMAL, ?string $reason = null): bool
     {
         try {
             if (!$this->handshaked) {

diff --git a/src/Exception/BadRequestException.php b/src/Exception/BadRequestException.php
@@ -7,7 +7,7 @@
 
 class BadRequestException extends HandshakeException
 {
-    public function __construct(string $message = '', int $code = null, Throwable $previous = null)
+    public function __construct(string $message = '', ?int $code = null, ?Throwable $previous = null)
     {
         parent::__construct($message, $code ?? Protocol::HTTP_BAD_REQUEST, $previous);
     }

diff --git a/src/Exception/CloseException.php b/src/Exception/CloseException.php
@@ -11,7 +11,7 @@
  */
 class CloseException extends WrenchException
 {
-    public function __construct(string $message = '', int $code = null, Throwable $previous = null)
+    public function __construct(string $message = '', ?int $code = null, ?Throwable $previous = null)
     {
         parent::__construct($message, $code ?? Protocol::CLOSE_UNEXPECTED, $previous);
     }

diff --git a/src/Exception/HandshakeException.php b/src/Exception/HandshakeException.php
@@ -8,7 +8,7 @@
 
 class HandshakeException extends WrenchException
 {
-    public function __construct(string $message = '', int $code = null, Throwable $previous = null)
+    public function __construct(string $message = '', ?int $code = null, ?Throwable $previous = null)
     {
         parent::__construct($message, $code ?? Protocol::HTTP_SERVER_ERROR, $previous);
     }

diff --git a/src/Exception/InvalidOriginException.php b/src/Exception/InvalidOriginException.php
@@ -10,7 +10,7 @@
  */
 class InvalidOriginException extends HandshakeException
 {
-    public function __construct(string $message = '', int $code = null, Throwable $previous = null)
+    public function __construct(string $message = '', ?int $code = null, ?Throwable $previous = null)
     {
         parent::__construct($message, $code ?? Protocol::HTTP_FORBIDDEN, $previous);
     }