Remove unused viewLayer and addons from CLI metadata
#1167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Package Size: 5576 KB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1167 +/- ##
==========================================
- Coverage 70.19% 70.00% -0.20%
==========================================
Files 203 202 -1
Lines 7385 7314 -71
Branches 1308 1301 -7
==========================================
- Hits 5184 5120 -64
+ Misses 2178 2171 -7
Partials 23 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justin-thurman
added
minor
justin-thurman
force-pushed
the
CAP-2359
branch
from
da169da to
5629e0a
Compare
jmhobbs
approved these changes
Mar 24, 2025
tevanoff
approved these changes
Apr 2, 2025
|
🚀 PR was released in |
chromatic-ci-bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
viewLayerandaddonsfrom the metadata calculated by the CLI. These values are no longer used, as this PR on the Chromatic repo.Note to Apps Team reviewer
Can you please confirm that nothing I'm removing here is actually needed? The PR linked above is fairly old. I did inspect the code, and it seems to be largely unchanged, but still, a second set of eyes would be much appreciated!
Manual QA
I ran a build locally using the changes from this PR, and everything worked as expected.
📦 Published PR as canary version:
11.29.0--canary.1167.14240886817.0✨ Test out this PR locally via: