-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ENH]: Get/Delete collection name validation + Get collection by ID #4381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[ENH]: Get/Delete collection name validation + Get collection by ID #4381
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas |
…_validation_get_collection_by_id
Collection Name Validation for Get/Delete + Get Collection by ID This PR introduces stricter validation for collection names when using the Get and Delete collection endpoints, ensuring they conform to defined naming rules (alphanumeric, length, and character constraints). Additionally, the Get Collection endpoint is enhanced to accept either a collection name or a collection UUID. Comprehensive backend Rust and generated TypeScript client changes are included, with new and expanded tests to validate both the functional and error cases. Key Changes: Affected Areas: This summary was automatically generated by @propel-code-bot |
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes