-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SunOS support #223
add SunOS support #223
Conversation
@cgrzemba I refactored the interface enumeration code a little. Could you please check if it still works. I removed the cleanup routine as there was no work in the class to be done, i.e. there is no socket to be closed or removed from event handling. In addition, I assume that |
There is an general issue with freeifaddrs so I do an explicit freeing like recommended here |
Should I merge the commits and do an forced update? |
I added freeing the returned interface address list when enumeration was successful. If that looks good, I'll go ahead and merge |
Because freeipaddr of libc ends in core I replace the function with a equivalent function in Python |
The first option, freeing immediate after use, would also work. |
Would be preferred, from my side, In addition, I wonder what the socket is used for: https://github.com/cgrzemba/wsdd/blob/6a6f76da8f1f2abd328dda7a2395f775baa4e457/src/wsdd.py#L1795 |
Thanks! I am fine with this code cleanup. |
Add initial support for SunOS/Illumos. Does not support dynamic address monitoring. Addresses are enumerated when wsdd starts up and changes are not tracked, which might be sufficient for static server environments. see christgau#223 Co-authored-by: Steffen Christgau <[email protected]>
This adds basic SunOS support tested on Illumos. Currently the NetworkAddressMonitor do not do dynamic network interface updates. The SMF manifest is not contained.