Merge pull request #59 from chrishumboldt/dev-rocket

Small fix to valued check.
chrishumboldt · Jan 12, 2017 · 10307c4 · 10307c4
2 parents 099e540 + 926000a
commit 10307c4
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 6 deletions.
diff --git a/build/js/form.js b/build/js/form.js
@@ -77,7 +77,7 @@ var RockMod_Form;
                 if (options.label.length > 0 && options.label !== 'normal') {
                     classes.push('_l-' + options.label);
                 }
-                if (typeof element.value === 'string' && element.value.length > 0) {
+                if (Rocket.exists(element) && Rocket.is.string(element.value) && element.value.length > 0) {
                     classes.push('_valued');
                 }
                 break;
@@ -92,7 +92,7 @@ var RockMod_Form;
                 if (options.label.length > 0 && options.label !== 'normal') {
                     classes.push('_l-' + options.label);
                 }
-                if (typeof element.value === 'string' && element.value.length > 0) {
+                if (Rocket.exists(element) && Rocket.is.string(element.value) && element.value.length > 0) {
                     classes.push('_valued');
                 }
         }

diff --git a/build/ts/form.ts b/build/ts/form.ts
@@ -92,7 +92,7 @@ module RockMod_Form {
             if (options.label.length > 0 && options.label !== 'normal') {
                classes.push('_l-' + options.label);
             }
-            if (typeof element.value === 'string' && element.value.length > 0) {
+            if (Rocket.exists(element) && Rocket.is.string(element.value) && element.value.length > 0) {
                classes.push('_valued');
             }
             break;
@@ -109,7 +109,7 @@ module RockMod_Form {
             if (options.label.length > 0 && options.label !== 'normal') {
                classes.push('_l-' + options.label);
             }
-            if (typeof element.value === 'string' && element.value.length > 0) {
+            if (Rocket.exists(element) && Rocket.is.string(element.value) && element.value.length > 0) {
                classes.push('_valued');
             }
 

diff --git a/build/ts/rocket-tools.d.ts b/build/ts/rocket-tools.d.ts
@@ -15,6 +15,7 @@ declare namespace Rocket {
 
    interface is {
       object(check: any): boolean;
+      string(check: any): boolean;
       touch(): boolean;
    }
    var is: is;

diff --git a/js/form.min.js b/js/form.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "rocket-form",
-  "version": "3.1.1",
+  "version": "3.1.2",
   "description": "A universal form module.",
   "main": "js/form.min.js",
   "repository": {