Add a flag -l to print the actions that were taken #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabicavalcante
changed the title
chriscz
requested changes
Oct 6, 2016
Owner
chriscz
left a comment
chriscz
left a comment
There was a problem hiding this comment.
You should also write a test case for your implementation :)
pysorter/core/sorter.py
Outdated
| do_recurse=False, | ||
| do_remove_empty_dirs=False): | ||
| do_remove_empty_dirs=False, | ||
| print_log=False): |
Owner
There was a problem hiding this comment.
Please use the do_ convention here
pysorter/filesystem.py
Outdated
| raise OSError("Source path is not a file: {}".format(src)) | ||
| #print "mv {} --> {}".format(src, dst) | ||
| if print_log: | ||
| print("mv {} --> {}".format(src, dst)) |
Owner
There was a problem hiding this comment.
Lift the move printing to the Pysorter.process method instead
pysorter/filesystem.py
Outdated
| raise OSError("Source path is not a directory: {}".format(src)) | ||
| #print "mvd {} --> {}".format(src, dst) | ||
| if print_log: | ||
| print("mvd {} --> {}".format(src, dst)) |
Author
|
I'm fixing the test, 1 min and I push it. |
Owner
|
Fixed the test yet? |
This was referenced Oct 10, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.