fix: give linked slots independent filler iterators via fork()#1956
Open
chrisbenincasa wants to merge 1 commit into
Open
fix: give linked slots independent filler iterators via fork()#1956chrisbenincasa wants to merge 1 commit into
chrisbenincasa wants to merge 1 commit into
Conversation
Linked slots (sharing an iterationGroup for rerun behavior) were producing identical filler content because they shared a single stateful filler iterator. Add a fork() method to ProgramIterator that creates fully independent copies, and call it in getFillerIteratorsForSlot when a slot's iteration group has already been seen. Content iterators remain shared (reruns work), but each slot now walks its own filler sequence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked slots (sharing an iterationGroup for rerun behavior) were
producing identical filler content because they shared a single
stateful filler iterator. Add a fork() method to ProgramIterator
that creates fully independent copies, and call it in
getFillerIteratorsForSlot when a slot's iteration group has
already been seen. Content iterators remain shared (reruns work),
but each slot now walks its own filler sequence.