Rework extension so that controls are bound to page where they are easier to use instead of in the popup, rework html files to make use of react, unhide divs if all elements hidden#49
Draft
barrymun wants to merge 22 commits into
Conversation
…s as the settings can be retrieved using the getSettings function
…for simplicity, remove the name key from package.json and setting it in common/manifest.json, as package.json does not allow spaces in the text value
…ncies and config, adding temp files for comparison with older popup script, new utility functions, support for translations (i18n), working on chrome but not on firefox (issue with script-src directive)
… error with firefox
…ponent' bugs, some popup style changes
…andard html popup
…excluding the run time
…search result query selector (it was previously grabbing divs that were not search results), rename popup.tsx to controls.tsx, adding flash-message context and component
…lve one final issue with port disconnection errors in the extension, ensure we wait for the settings to exist in the use-settings context, remove getMessage function as it is no longer required (using next-i18n)
…file for autocomplete
… webpack build config for production mode
…his is now managed from a container bound to the page using the content script, the container can be toggled opened|closed using a toggle with the extension logo, popup is now more informational, adding light|dark mode, adding missing icons, rounded the corners of the icons for a cleaner look, various typings changes for webpack, additional installs, altering the post-build script slightly, updating the messages to handle new keys (added to all translations files)
… as opposed to everything in a particular lib, adding some webpack analyser tools
…on page load (transition applied immediately when it should be delayed)
barrymun
changed the title
barrymun
changed the title
…or directory structure so that it is cleaner, moving types into a @types directory at the same level as the src directory
…command on tsx files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes
reactinstead of regular html@muiis the chosen ui libraryamazon.<whatever>page where an iframe renders the relevant component740kb(further improvement possible, but this is decent for now)webpack build size analysis