Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Exclude support branches to branch filters #3624

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

AdmiringWorm
Copy link
Member

Description Of Changes

This updates the branch filter for the normal Chocolatey build to
exclude any support branches from being built by our internal build
server.

Motivation and Context

We do not want support branches to build directly when they are not tagged, similar to how we are expecting builds to happen for the master branch.

Testing

N/A, can this be tested?

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

N/A

This updates the branch filter for the normal Chocolatey build to
exclude any support branches from being built by our internal build
server.
@AdmiringWorm AdmiringWorm self-assigned this Feb 4, 2025
@AdmiringWorm AdmiringWorm requested review from gep13 and Windos February 4, 2025 09:45
This includes some updates to improve the release process from Support
Branches, however, it makes sense to use it on all branches.
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 522172c into chocolatey:develop Feb 4, 2025
5 checks passed
@gep13
Copy link
Member

gep13 commented Feb 4, 2025

@AdmiringWorm thanks for getting this done!

@AdmiringWorm AdmiringWorm deleted the exclude-support branch February 4, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants