(#3621) Skip trace warning when trace not used #3623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the warning that is outputted in non-elevated mode to not be outputted when the user has not specified `--trace` on the commandline. Without this change, any time a use are running in a non-elevated mode, they will always have the trace warning outputted even when they haven't used the argument.
This includes some updates to improve the release process from Support Branches.
|
The failing build here is on Ubuntu, which has been seeing issues lately, so going to ignore for the purposes of getting this PR merged. |
|
@AdmiringWorm thanks for getting this fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This updates the warning that is outputted in non-elevated mode to not
be outputted when the user has not specified
--traceon thecommandline.
Motivation and Context
Without this change, any time a use are running in a non-elevated mode,
they will always have the trace warning outputted even when they haven't
used the argument.
Testing
Do the following tests in a non-elevated window.
choco search chocolatey(or any other command not requiring admin privileges).--tracenot being supported are not shown.--trace.--traceare now outputted.In an admin window repeat the above tests, verifying that the trace warning is not outputted.
Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #3621