(#3618) Ensure ILMerge can run #3619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously in chocolatey#3609 we removed the No7zip build configuration. This build configuration set itself as a dependee of ILMerge, and a Dependent of Build and Test. This resulted in the ILMerge task being dependent upon Build and Test. This commit sets the ILMerge task to be dependent upon both Build and Test so that builds that target just the ILMerge can succeed.
|
@corbob I am going to go ahead and close this PR, since this has been addressed in the latest version of Chocolatey.Cake.Recipe, which we are going to upgrade to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Previously in #3609 we removed the No7zip build configuration. This build configuration set itself as a dependee of ILMerge, and a Dependent of Build and Test. This resulted in the ILMerge task being dependent upon Build and Test.
This commit sets the ILMerge task to be dependent upon both Build and Test so that builds that target just the ILMerge can succeed.
Motivation and Context
Ensure we can do an ILMerge without needing to run other tasks first.
Testing
git clean -xdfto remove all non-commited files..\build.bat --target=Run-ILMergeOperating Systems Testing
Windows 11
Change Types Made
Change Checklist
Related Issue
Run-ILMergetask in build #3618