(#2712) Normalize ExitCode pester tests #3373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We haven't been consistent when checking the exit code of the Chocolatey command run. This commit updates all instances where we're testing ExitCode on the output object to also include the String propery if the ExitCode doesn't match. This allows us to better deduce issues as we have the Chocolatey output as well.
corbob
changed the title
corbob
changed the title
|
@corbob thank you for getting these fixed up! This is going to help a LOT! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Normalize the exit code checking of the Pester tests.
Motivation and Context
This normalizes the exit code checking of the pester tests so that if they don't return as expected we have the output of the command.
Testing
Ran through Test Kitchen in Team City (see link to gep13 in Slack)
Operating Systems Testing
Windows Server 2016/2019
Change Types Made
Change Checklist
Related Issue