Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make readonly inputs appear disabled #441

Conversation

alexaveldanez
Copy link
Contributor

Description Of Changes

Makes read only inputs the same background color as disabled inputs.

Motivation and Context

This change is needed for WCAG compliance.

Testing

  1. Login to CCM.
  2. Click Software on side nav bar.
  3. Click Edit from Actions drop down button next to any software from the list.
  4. Edit Software modal appears.
  5. The read only inputs should appear the same color as the disabled inputs.

Operating Systems Testing

Windows 10 Pro

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

#1001
Fixes #1001

Makes the background color on readonly inputs the same as disabled inputs.
@alexaveldanez alexaveldanez force-pushed the make-readonly-inputs-appear-disabled branch from a0d11a5 to 8ddc921 Compare February 10, 2025 15:59
@st3phhays st3phhays self-requested a review February 10, 2025 16:05
Copy link
Member

@st3phhays st3phhays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@st3phhays st3phhays merged commit 4f29d74 into chocolatey:release/accessibility-phase1 Feb 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants