Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#415)(#416)(#417)(#418) choco-theme 0.8.1 #419

Closed
wants to merge 4 commits into from

Conversation

st3phhays
Copy link
Member

Description Of Changes

  • Upgrades ESLint to 9.x
  • Fixes PT Sans font path for docs
  • Adds scanning of all dependencies for security vulnerabilities
  • Upgrades miscellaneous dependencies and upgrades to choco-theme 0.8.1

Motivation and Context

There were a few dependencies that needed upgraded to allow the yarn npm audit command to pass. We want to ship up to date dependencies and remove any vulnerabilities. In addition, the font path to the docs needed fixed to ensure fonts were shown the same for all users.

Testing

TBD.

Operating Systems Testing

  • choco-theme 0.8.1 on Windows 10

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

This updates the yarn npm audit command to include all severity
types, scan dependencies recursively, and also ignores the known
vulnerability in sweetalert2.

This command has been added to the readme, which can be ran locally
after `yarn` has been ran. In addition, this has been updated in the
audit.yaml file that is ran before choco-theme is released.
This updates the path to which the PT Sans font should be copied to on
the docs site. This removes the duplicate 'fons' in the path. This
allows the font to be copied correctly when `yarn choco-theme` is ran
on the docs site.
@st3phhays st3phhays self-assigned this Sep 25, 2024
@st3phhays
Copy link
Member Author

This PR is to remain in draft until all other PRs that use this are have been reviewed and approved. This is to ensure that everything that uses this version of choco-theme has been tested and passes.

This upgrades to the latest version of ESLint. With this upgrade, the
format of the config file change to a `eslint.config.mjs` file. A tool
was used by ESLint to convert over the existing .eslintrc.js file. More
information on the conversion can be found at https://eslint.org/docs/latest/use/configure/migration-guide.

After this upgrade of ESLint, ESLint was ran and tested by making
purposeful changes to ensure that errors were caught. This worked
successfully, and also found an actual error that was fixed.
This upgrades choco-theme to 0.8.1. With this upgrade, typescript and
purgecss were upgraded to remove any possible vulnerabilities. Other
than that, no specific changes were made although the compiled code
changed slightly due to additional dependencies being upgraded to minor
versions by removing and regenerating the yarn.lock file.
@st3phhays
Copy link
Member Author

Closing this PR in favor of #420

@st3phhays st3phhays closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant