Fix windows build #82
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 tasks
JamesMGreene
added a commit
to JamesMGreene/node-partty
that referenced
this pull request
Jun 22, 2015
|
When will this be merged? Really need to get it work on Windows |
|
@wangtao2012 I've forked pty.js, bringing better node and windows support and fixing a bunch of bugs. Check it out at https://github.com/Tyriar/node-pty |
ddm
pushed a commit
to ddm/pty.js
that referenced
this pull request
Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the delete statement was just a typo. Also, needs to use the latest version of peters/winpty. Thanks to @peters for merging that.