Skip to content

Add missing implies for BitsIntf #5055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

Add missing implies for BitsIntf #5055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/src/main/scala-3/chisel3/BitsIntf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,4 +597,11 @@ private[chisel3] trait BoolIntf extends ToBoolable { self: Bool =>
def asClock(using SourceInfo): Clock = _asClockImpl

def asAsyncReset(using SourceInfo): AsyncReset = _asAsyncResetImpl

/** Logical implication
*
* @param that a boolean signal
* @return [[!this || that]]
*/
def implies(that: Bool): Bool = (!this) | that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not duplicate the implementation, instead we should put the single implementation in a private method that is called here (like the functions above). This also should have SourceInfo.

}
Loading