Merge pull request #610 from chinapandaman/PPF-609

PPF-609: add cache to get_widgets_by_page
chinapandaman · May 4, 2024 · 6c89a97 · 6c89a97
2 parents 8711cfd + 39a98dc
commit 6c89a97
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/PyPDFForm/template.py b/PyPDFForm/template.py
@@ -1,6 +1,7 @@
 # -*- coding: utf-8 -*-
 """Contains helpers for generic template related processing."""
 
+from functools import lru_cache
 from sys import maxsize
 from typing import Dict, List, Tuple, Union
 
@@ -138,6 +139,7 @@ def update_text_field_attributes(
                     )
 
 
+@lru_cache()
 def get_widgets_by_page(pdf: bytes) -> Dict[int, List[dict]]:
     """Iterates through a PDF and returns all widgets found grouped by page."""
 

diff --git a/scripts/new_pdf_samples.sh b/scripts/new_pdf_samples.sh
@@ -2,4 +2,4 @@ if [[ "$VIRTUAL_ENV" == "" ]]; then
   source "./venv/bin/activate"
 fi
 
-pytest -s --regenerate=1
+pytest --regenerate=1
diff --git a/scripts/pdf_diffs.sh b/scripts/pdf_diffs.sh
@@ -2,7 +2,7 @@ if [[ "$VIRTUAL_ENV" == "" ]]; then
   source "./venv/bin/activate"
 fi
 
-pytest -s --regenerate=1
+pytest --regenerate=1
 
 BEFORE=()
 

diff --git a/scripts/test.sh b/scripts/test.sh
@@ -2,4 +2,4 @@ if [[ "$VIRTUAL_ENV" == "" ]]; then
   source "./venv/bin/activate"
 fi
 
-coverage run -m pytest -s && coverage report --fail-under=100
+coverage run -m pytest && coverage report --fail-under=100