Skip to content

Don't need to sort Array. Slows down computation #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Reza88 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't need to sort Array. Slows down computation #16

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e40ca1f
Don't need to sort Array. Slows down computation
Aug 4, 2017
70672b3
Update 532. K-diff Pairs in an Array.js
Reza88 Aug 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions 532. K-diff Pairs in an Array.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
var findPairs = function(nums, k) {
if(nums.length === 0 || k < 0) {
return 0;
}
var dict = {};
var count = 0;
if (nums.length === 0 || k < 0) {
return 0;
}
var dict = {};
var count = 0;

nums.sort(function(a,b){ return a - b });
for(var i = 0; i < nums.length; i++) {
var number = nums[i];
dict[number] = (dict[number] === undefined)? 1 : dict[number] += dict[number];
}
for(var numb in dict) {
numb = parseInt(numb);
if(k === 0) {
if(dict[numb] > 1) {
count++;
}
} else if(dict[numb + k] !== undefined){
count++;
//nums.sort(function(a,b){ return a - b });
Copy link
Contributor

@ignacio-chiazzo ignacio-chiazzo Aug 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this line

Copy link
Author

@Reza88 Reza88 Aug 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

for (var i = 0; i < nums.length; i++) {
var number = nums[i];
dict[number] = (dict[number] === undefined) ? 1 : dict[number] += dict[number];
}
for (var numb in dict) {
numb = parseInt(numb);
if (k === 0) {
if (dict[numb] > 1) {
count++;
}
} else if (dict[numb + k] !== undefined) {
count++;
}
}
}
return count;
};
return count;
};