Repository navigation
Keep the workspace in the URL and follow the server's default - #27
Merged
Merged
Conversation
A link copied from the address bar had no workspace in it, so it opened in whatever workspace the recipient's browser last used, often the empty built-in "default", and a doc link 404'd. The UI now writes ?workspace= into the URL whenever the workspace is chosen or adopted, keeping the #/doc/... hash. With nothing saved, the UI used to pick "default" by name. It now asks the server which workspace an unscoped request lands in, so an instance whose DEFAULT_WORKSPACE is something else opens there. A browser whose only saved choice is "default" follows the server's default too; an explicit ?workspace= link is always kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A link copied from the address bar carried no workspace, so it opened in whatever workspace the recipient last used, often the empty built-in
default, and doc links 404ed.?workspace=into the URL whenever the workspace is chosen or adopted, keeping the#/doc/...hash.X-Workspaceresponse header) instead of a hardcodeddefault.defaultfollows the server's default; an explicit?workspace=link always wins.