test: #255 10_minimum_example/060_template_compiler2 #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2nofa11
commented
Feb 9, 2024
| expect(host.innerHTML).toBe( | ||
| `<div class="container" style="text-align: center"> | ||
| <h2>Hello, chibivue!</h2> | ||
| <img width="150px" src="https://upload.wikimedia.org/wikipedia/commons/thumb/9/95/Vue.js_Logo_2.svg/1200px-Vue.js_Logo_2.svg.png" alt="Vue.js Logo"> |
There was a problem hiding this comment.
[fyi]
Slightly different from argument of createApp method.
- Argument of createApp(L20-L24)
→ with line feed and "/". - This line
→ without line feed and "/"
There was a problem hiding this comment.
Hmm, I see.
I'm a bit hesitant, but for now, I'll consider it not a problem!
ubugeeei
approved these changes
Feb 9, 2024
| expect(host.innerHTML).toBe( | ||
| `<div class="container" style="text-align: center"> | ||
| <h2>Hello, chibivue!</h2> | ||
| <img width="150px" src="https://upload.wikimedia.org/wikipedia/commons/thumb/9/95/Vue.js_Logo_2.svg/1200px-Vue.js_Logo_2.svg.png" alt="Vue.js Logo"> |
There was a problem hiding this comment.
Hmm, I see.
I'm a bit hesitant, but for now, I'll consider it not a problem!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a test case based on the PR.
[Info]
Because the line break position of the img tag is changed by compilation, the code of the img tag in the forecast result is slightly different from the input content.(here is the target line)
[Other Solutions]
Also, please let me know if you prefer to test using "querySelector" as a testing method.
related: https://github.com/Ubugeeei/chibivue/issues/255