feat: 회원 서비스 알림 및 마케팅 수신 동의 토글 API 구현 #210
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yongjun0511
reviewed
Sep 13, 2025
| this.status = status; | ||
| this.serviceAlarmAgree = serviceAlarmAgree; | ||
| this.marketingAgree = marketingAgree; | ||
| } |
Collaborator
There was a problem hiding this comment.
Term에 대한 부분 초창기에 이야기를 했던 부분인데요 Term이 하나 이상이기도 하고 분리하는게 좋아보입니다!
Term을 언제 동의 했는지 보통 기록한다고 하더라구요? 그럴려면 매핑 엔티티로 관리하고 거기서 update 시간을 기록할태니 ...
그 방향이 좋지 않나 생각합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
📚 참고사항