feat(feishu): add custom domain configuration option#412
Open
feat(feishu): add custom domain configuration option#412
Conversation
Add optional `domain` parameter for Feishu/Lark platforms to support custom Feishu deployments. The underlying SDK already supports custom domains, but the configuration layer didn't expose this capability. Usage in config.toml: [[projects.platforms]] type = "feishu" [projects.platforms.options] app_id = "cli_xxx" app_secret = "secret" domain = "https://custom.feishu.cn" # optional Default behavior is unchanged - Feishu uses open.feishu.cn and Lark uses larksuite.com when domain is not specified. Closes #402 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
|
LGTM! Clean implementation of custom domain configuration. ✅ Feature correctness:
✅ Tests: Added ✅ CI: All checks pass. Ready for merge. |
Owner
Author
|
This PR has merge conflicts with the main branch. Please resolve the conflicts: git fetch origin
git checkout feat-feishu-custom-domain
git merge origin/main
# Resolve conflicts, then:
git pushOnce resolved, the PR can proceed to review and merge. |
chenhg5
commented
Apr 3, 2026
Owner
Author
chenhg5
left a comment
chenhg5
left a comment
There was a problem hiding this comment.
此 PR 有 merge conflicts，需要解决后再合并。
请 rebase 到最新的 main 分支并解决冲突。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
domainparameter for Feishu/Lark platformsUsage
Test plan
go build ./...passesgo vet ./...passesgo test ./platform/feishu/...passes (all tests including new custom domain tests)Closes #402