-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMLE training #35
Merged
Merged
EMLE training #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # emle/train/_aev_calculator.py # emle/train/_trainer.py # emle/train/_utils.py
…ckends in _analyzer.py
Ready to go. Changes:
@JMorado, feel free to add to the list if I forgot anything substantial! |
Many thanks for this. I've merged into my |
Many thanks to both of you. Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
EMLETrainer
class andemle-trainer
script that exposes training as CLI. The reference data is expected in the same format asemle-analyse
(a tarball with ORCA and horton outputs). This should facilitate active learning, where error analysis and retraining is performed for the same data.Main changes to the common codebase:
EMLEAEVComputer
class. This includes masking, normalization, and mapping between EMLE andAEVComputer
zid
values (the latter only needed when using a common computer withani2x
)1e-16
) was added in various places inEMLEBase
to avoidnan
in the gradients w.r.t. EMLE parameters. Before it was not needed, since the gradients were only calculated w.r.t. atomic positionsaev_mean
feature was removed