Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant attributes and kwargs now that the species are encoded in future models #31

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Remove redundant attributes and kwargs now that the species are encoded in future models #31

merged 2 commits into from
Oct 23, 2024

Conversation

lohedges
Copy link
Contributor

This PR removes the species related attributes, kwargs, and environment variables, since this is now encoded in the EMLE model itself. Users of existing custom models will need to add a species key to their model files.

@lohedges lohedges added the enhancement New feature or request label Oct 23, 2024
@lohedges lohedges requested a review from kzinovjev October 23, 2024 09:54
@lohedges lohedges merged commit cd9633a into main Oct 23, 2024
@lohedges lohedges deleted the feature_species branch October 23, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzinovjev kzinovjev kzinovjev approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lohedges @kzinovjev