-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ubuntu 22.04 #369
base: main
Are you sure you want to change the base?
Add Ubuntu 22.04 #369
Conversation
Are changes needed here? This PR has been open for 4 months without a response. Ubuntu 22.04 was released nearly 9 months ago. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There also need to be changes to platforms.json
https://github.com/chefspec/fauxhai/pull/372/files
|
I have updated |
@buck3tsec I just got the following word from Chef via Slack:
|
Hi! Is there any way we can do to keep pushing this forward? |
Yeah, by filing the PR here instead i guess chef/fauxhai. Everything is so frustratingly slow regarding Chef lately. How does something simple like a new Ubuntu release take over a year and still not make it into Fauxhai? How does Chef 17, which is technically still in support, and whose latest stable release contains a vulnerable version of openssl, not get any release since over a year?! |
So the chefspec/fauxhai is dead now? Is anyone planning to re-submit over in chef/fauxhai? |
also probably want to update |
Hopefully I'm not overstepping but I went ahead and ported this PR over to chef#16. |
FYI (as you can see) the chef/fauxhai PR has been merged. I imagine this PR could be closed. Now to figure out how to change our pipeline to use it. :) |
Looks like this is still a problem. Is there any way we can get 22.04 support merged in? |
@blackknight36 Have you tried to use it from the chef/fauxhai fork? As noted above, this repo is no longer being maintained. |
thanks for working on the PR @dtseiler awesome work! did you have success on using it from chef/fauxai? I saw a note from the changelog that it wasn't released yet https://github.com/chef/fauxhai/blob/main/CHANGELOG.md#changes-not-yet-released-to-rubygemsorg |
@blackknight36 Progress incorrectly removed all non employees from this repo and somehow doesn't have the gem access anymore. It's a dead repo. Use their fork instead |
@shierro unfortunately I haven't had a chance to actually use it, sorry. |
Thanks. I'll look into using the other version. |
Two notes:
CONTRIBUTING.md
was unsuccessful for me. I had torequire 'fauxhai'
and even then it was all false positives. For example,Fauxhai.mock(platform: 'ubuntu', version: '45.04')
did not generate errors.22.04.json
into my actualfauxhai
installation and this worked for a basicrspec
test ofplatform 'ubuntu', '22.04'
.