Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu 22.04 #369

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Ubuntu 22.04 #369

wants to merge 2 commits into from

Conversation

smcgu
Copy link

@smcgu smcgu commented Sep 27, 2022

Two notes:

  1. Step 10 of CONTRIBUTING.md was unsuccessful for me. I had to require 'fauxhai' and even then it was all false positives. For example, Fauxhai.mock(platform: 'ubuntu', version: '45.04') did not generate errors.
  2. I dropped 22.04.json into my actual fauxhai installation and this worked for a basic rspectest of platform 'ubuntu', '22.04'.

@benlemasurier
Copy link

Are changes needed here? This PR has been open for 4 months without a response. Ubuntu 22.04 was released nearly 9 months ago.

Copy link

@tpowell-progress tpowell-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There also need to be changes to platforms.json https://github.com/chefspec/fauxhai/pull/372/files

@benlemasurier benlemasurier mentioned this pull request Jan 31, 2023
@benlemasurier
Copy link

There also need to be changes to platforms.json https://github.com/chefspec/fauxhai/pull/372/files

#373

@smcgu
Copy link
Author

smcgu commented Jan 31, 2023

There also need to be changes to platforms.json https://github.com/chefspec/fauxhai/pull/372/files

I have updated platforms.json. If this is needed for PRs, probably a good idea to update CONTRIBUTING.md to include this step.

@ramereth
Copy link
Contributor

ramereth commented Feb 1, 2023

@buck3tsec I just got the following word from Chef via Slack:

Please note, fauxhai ruby gem is being published from the chef/fauxhai fork since last year. this was done as we had lost access/ contact to original chefspec org.

@shierro
Copy link

shierro commented Mar 24, 2023

Hi! Is there any way we can do to keep pushing this forward?

@hrak
Copy link

hrak commented Apr 19, 2023

Yeah, by filing the PR here instead i guess chef/fauxhai.

Everything is so frustratingly slow regarding Chef lately. How does something simple like a new Ubuntu release take over a year and still not make it into Fauxhai? How does Chef 17, which is technically still in support, and whose latest stable release contains a vulnerable version of openssl, not get any release since over a year?!

@dtseiler
Copy link

dtseiler commented Jun 2, 2023

So the chefspec/fauxhai is dead now? Is anyone planning to re-submit over in chef/fauxhai?

@dtseiler
Copy link

dtseiler commented Jun 2, 2023

also probably want to update PLATFORMS.md to add 22.04 as well.

@dtseiler
Copy link

dtseiler commented Jun 2, 2023

Hopefully I'm not overstepping but I went ahead and ported this PR over to chef#16.

@dtseiler
Copy link

dtseiler commented Aug 9, 2023

FYI (as you can see) the chef/fauxhai PR has been merged. I imagine this PR could be closed. Now to figure out how to change our pipeline to use it. :)

@blackknight36
Copy link

Looks like this is still a problem. Is there any way we can get 22.04 support merged in?

@dtseiler
Copy link

@blackknight36 Have you tried to use it from the chef/fauxhai fork? As noted above, this repo is no longer being maintained.

@shierro
Copy link

shierro commented Oct 20, 2023

thanks for working on the PR @dtseiler awesome work!

did you have success on using it from chef/fauxai? I saw a note from the changelog that it wasn't released yet

https://github.com/chef/fauxhai/blob/main/CHANGELOG.md#changes-not-yet-released-to-rubygemsorg

@tas50
Copy link
Contributor

tas50 commented Oct 20, 2023

@blackknight36 Progress incorrectly removed all non employees from this repo and somehow doesn't have the gem access anymore. It's a dead repo. Use their fork instead

@dtseiler
Copy link

@shierro unfortunately I haven't had a chance to actually use it, sorry.

@blackknight36
Copy link

@blackknight36 Progress incorrectly removed all non employees from this repo and somehow doesn't have the gem access anymore. It's a dead repo. Use their fork instead

Thanks. I'll look into using the other version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants