Move ffi dependency forward #81
Open
+8
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for Ruby 3.3, but works on 3.1+ Signed-off-by: Phil Dibowitz <[email protected]>
|
| @@ -8,29 +8,29 @@ expeditor: | |||
|
|
|||
| steps: | |||
|
|
|||
| - label: run-lint-and-specs-ruby-2.7 | |||
| - label: run-lint-and-specs-ruby-3.0 | |||
There was a problem hiding this comment.
Let's just go with a minor version bump and remove this validation?
| @@ -13,5 +13,6 @@ Gem::Specification.new do |gem| | |||
| gem.require_paths = ["lib"] | |||
| gem.required_ruby_version = ">= 2.7" | |||
There was a problem hiding this comment.
Probably should just declare that 3.1 is the minimum now, given that securerandom triggers:
Resolving dependencies...................................
securerandom-0.4.1 requires ruby version >= 3.1.0, which is incompatible with
the current version, ruby 3.0.7p220
🚨 Error: The command exited with status 1
tpowell-progress
requested changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for Ruby 3.3, but works on 3.1+