-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated ruby version to 3.1. #3953
Conversation
👷 Deploy Preview for chef-server processing.
|
f1acf49
to
c46710a
Compare
.expeditor/verify.pipeline.yml
Outdated
@@ -18,14 +18,14 @@ steps: | |||
# Lint Tests | |||
######################################################################### | |||
|
|||
- label: license-scout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't safely merge without resolving license scout issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sreepuramsudheer Please revert this change.
.expeditor/automate_build.sh
Outdated
@@ -42,6 +42,7 @@ HAB_FEAT_OFFLINE_INSTALL=true HAB_FEAT_IGNORE_LOCAL=false HAB_ORIGIN=chef HAB_CA | |||
|
|||
git clone https://github.com/chef/automate.git | |||
cd automate | |||
git checkout ssudheer/ruby_update_3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a temporary change? Can we make this configurable? Future work ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made it configurable.
.expeditor/chef_server.sh
Outdated
@@ -6,7 +6,7 @@ | |||
|
|||
git clone https://github.com/chef/automate.git | |||
cd automate | |||
git checkout kalroy/cs_plan_changes | |||
git checkout ssudheer/ruby_update_3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it configurable but for now it's ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made it configurable.
.license_scout.yml
Outdated
@@ -213,4 +213,6 @@ exceptions: | |||
reason: Exception made by Chef Legal | |||
- name: core/nss-myhostname | |||
reason: Exception made by Chef Legal | |||
- name: core/xz | |||
reason: Added for test to pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the comment accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment updated to "Exception made by Chef Legal".
56f25df
to
88cc3a9
Compare
88cc3a9
to
891d82d
Compare
Signed-off-by: sreepuramsudheer <[email protected]>
Signed-off-by: sreepuramsudheer <[email protected]>
Signed-off-by: sreepuramsudheer <[email protected]>
Signed-off-by: sreepuramsudheer <[email protected]>
Signed-off-by: sreepuramsudheer <[email protected]>
Signed-off-by: sreepuramsudheer <[email protected]>
Signed-off-by: sreepuramsudheer <[email protected]>
891d82d
to
6b1c34f
Compare
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
Description
[Please describe what this change achieves]
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List