Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ruby version to 3.1. #3953

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Updated ruby version to 3.1. #3953

merged 7 commits into from
Dec 11, 2024

Conversation

sreepuramsudheer
Copy link
Contributor

Description

[Please describe what this change achieves]

Issues Resolved

[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]

Check List

@sreepuramsudheer sreepuramsudheer requested review from a team as code owners December 2, 2024 23:56
Copy link

netlify bot commented Dec 2, 2024

👷 Deploy Preview for chef-server processing.

Name Link
🔨 Latest commit 6b1c34f
🔍 Latest deploy log https://app.netlify.com/sites/chef-server/deploys/67592078375ed900089be0bf

@sreepuramsudheer sreepuramsudheer force-pushed the ssudheer/CHEF-17460 branch 3 times, most recently from f1acf49 to c46710a Compare December 3, 2024 08:06
@@ -18,14 +18,14 @@ steps:
# Lint Tests
#########################################################################

- label: license-scout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't safely merge without resolving license scout issues.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sreepuramsudheer Please revert this change.

@sreepuramsudheer
Copy link
Contributor Author

sreepuramsudheer commented Dec 9, 2024

@jashaik
Copy link
Contributor

jashaik commented Dec 9, 2024

@@ -42,6 +42,7 @@ HAB_FEAT_OFFLINE_INSTALL=true HAB_FEAT_IGNORE_LOCAL=false HAB_ORIGIN=chef HAB_CA

git clone https://github.com/chef/automate.git
cd automate
git checkout ssudheer/ruby_update_3.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a temporary change? Can we make this configurable? Future work ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made it configurable.

@@ -6,7 +6,7 @@

git clone https://github.com/chef/automate.git
cd automate
git checkout kalroy/cs_plan_changes
git checkout ssudheer/ruby_update_3.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it configurable but for now it's ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made it configurable.

@@ -213,4 +213,6 @@ exceptions:
reason: Exception made by Chef Legal
- name: core/nss-myhostname
reason: Exception made by Chef Legal
- name: core/xz
reason: Added for test to pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the comment accordingly.

Copy link
Contributor Author

@sreepuramsudheer sreepuramsudheer Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment updated to "Exception made by Chef Legal".

@jashaik jashaik force-pushed the ssudheer/CHEF-17460 branch from 891d82d to 6b1c34f Compare December 11, 2024 05:17
@jashaik jashaik merged commit 599127a into main Dec 11, 2024
9 of 12 checks passed
@jashaik jashaik deleted the ssudheer/CHEF-17460 branch December 11, 2024 05:18
Copy link

sonarcloud bot commented Dec 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants