-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update from main #623
Merged
Merged
Update from main #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expecting bugs!
Deploying phanpy with
|
Latest commit: |
be4ef56
|
Status: | ✅ Deploy successful! |
Preview URL: | https://5d16a63e.phanpy.pages.dev |
Branch Preview URL: | https://main.phanpy.pages.dev |
And see if these strings can sync up
Instead of one, should use _1 because string for "one" has to be shown regardless of plural forms When 1, "{account} followed you" must show instead of "1 people followed you". Some languages don't have plural rule for "one" so it might not show up. _1 forces it to show.
Hmm, this diff change is kinda noisy but useful to jump straight to the line
Not everything is fully translated yet, so it's weird to see all of them in PR
And see the line numbers change again in translation files
Prevents the lang selector from being jumpy
Could be the file is not there or something wrong with the connection. Still good to include this try/catch
Dangerous move, but oh well.
Reference: mastodon/mastodon#31342 Very MVP, not a lot of explanations. Maybe revisit later.
Without clean, the code diff is really ugly and hard to track
react-menu changed it to role="none"
* New translations (Kabyle) * New translations (Basque) * New translations (Polish) * New translations (Spanish) * New translations (Chinese Simplified) * Update catalogs.json --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* New translations (Portuguese) * New translations (Russian) * New translations (Korean) * Update catalogs.json * New translations (Galician) --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* New translations (Italian) * Update catalogs.json --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* New translations (Portuguese, Brazilian) * Update catalogs.json --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* New translations (Portuguese) * New translations (Portuguese, Brazilian) * Update catalogs.json --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* New translations (Portuguese) * New translations (Portuguese, Brazilian) * Update catalogs.json --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* New translations (Portuguese, Brazilian) * Update catalogs.json --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* New translations (Russian) * New translations (Portuguese, Brazilian) * Update catalogs.json --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* New translations (Portuguese, Brazilian) * Update catalogs.json --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* New translations (Portuguese) * New translations (Portuguese, Brazilian) * Update catalogs.json --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* New translations (Portuguese) * New translations (Portuguese, Brazilian) * Update catalogs.json --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to update from branch main