Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: instead of just having a VERSION file, bump chectl version to match release version (0.0.2 --> 7.yy.0) #2782

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

nickboldt
Copy link
Collaborator

@nickboldt nickboldt commented Oct 10, 2023

What does this PR do?

chore: instead of just having a VERSION file, bump chectl version to match release version (0.0.2 --> 7.yy.0)

Change-Id: Id9133f0e7f6bb738f8625fd3bdc79730df6a004e
Signed-off-by: Nick Boldt [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

Sort of related to https://issues.redhat.com/browse/CRW-4922 -- discovered while trying to figure out what's borked there.

How to test this PR?

  1. check out branch
  2. yarn
  3. ./bin/run --help to see the version
  4. can also build binaries with yarn pack-binaries and then install from one of those

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

… bump the version of chectl to match the release version (0.0.2 --> 7.yy.0)

Change-Id: I52ab535adece48e61da6ec69cee934694c1b3cb3
Signed-off-by: Nick Boldt <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt nickboldt changed the title use latest node 18.18.0 in... chore: instead of just having a VERSION file, we should ALSO actually bump the version of chectl to match the release version (0.0.2 --> 7.yy.0); use latest node 18.18.0 in workflows Oct 10, 2023
@nickboldt nickboldt changed the title chore: instead of just having a VERSION file, we should ALSO actually bump the version of chectl to match the release version (0.0.2 --> 7.yy.0); use latest node 18.18.0 in workflows chore: instead of just having a VERSION file, bump chectl version to match release version (0.0.2 --> 7.yy.0) Oct 10, 2023
@tolusha tolusha merged commit a36ccc4 into main Oct 11, 2023
10 checks passed
@tolusha tolusha deleted the correct-version branch October 11, 2023 06:39
@devstudio-release
Copy link

Build 3.10 :: dsc_3.x/1463: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: dsc_3.x/1463: SUCCESS

3.10.0-CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants