Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection_wrapper destructor sometimes closing other connections #312

Merged
merged 3 commits into from
Mar 25, 2025
Merged

Fix connection_wrapper destructor sometimes closing other connections #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
274fd11
Fix race condition where destroying a closed connection can close a d…
meastham Mar 21, 2025
1b98b4e
Update AUTHORS.md
auxten Mar 24, 2025
a39625c
Update AUTHORS.md
auxten Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions AUTHORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,18 @@
# Contributors

* auxten [[email protected]](mailto:[email protected])
* Daniel Robbins [[email protected]](mailto:[email protected])
* Lorenzo Mangani [[email protected]](mailto:[email protected])
* nmreadelf [[email protected]](mailto:[email protected])
* laodouya [[email protected]](mailto:[email protected])
* DemoYeti [[email protected]](mailto:[email protected])
* Michael Razuvaev [[email protected]](mailto:[email protected])
* Nevin [[email protected]](mailto:[email protected])
* Yunyu Lin [[email protected]](mailto:[email protected])
* reema93jain [[email protected]](mailto:[email protected])
* xinhuitian [[email protected]](mailto:[email protected])
* Alex Bocharov [[email protected]](mailto:[email protected])
* meastham [[email protected]](mailto:[email protected])

To see the list of authors who created the source code of ClickHouse, published and distributed by ClickHouse, Inc. as the owner,
run "SELECT * FROM system.contributors;" query on any ClickHouse server.
8 changes: 6 additions & 2 deletions programs/local/LocalChdb.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,12 @@ connection_wrapper::~connection_wrapper()

void connection_wrapper::close()
{
py::gil_scoped_release release;
close_conn(conn);
{
py::gil_scoped_release release;
close_conn(conn);
}
// Ensure that if a new connection is created before this object is destroyed that we don't try to close it.
conn = nullptr;
}

cursor_wrapper * connection_wrapper::cursor()
Expand Down