Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App migration fixes - session paths 404, email settings #1296

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

annarhughes
Copy link
Member

What changes did you make and why did you make them?

Resolves the following issues related to app router migration #1279

  • fixes session pages not being statically generated due to paths missing sessionSlug param, causing 404s on staging
  • fixes email settings form state
  • fixes video config param error

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bloom-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 6:22pm

@annarhughes annarhughes merged commit af64522 into develop Feb 5, 2025
7 checks passed
@annarhughes annarhughes deleted the app-migration-fixes-2 branch February 5, 2025 18:22
Copy link

cypress bot commented Feb 5, 2025

Bloom frontend    Run #979

Run Properties:  status check passed Passed #979  •  git commit af64522001: fix: migration session paths 404, email settings (#1296)
Project Bloom frontend
Branch Review develop
Run status status check passed Passed #979
Run duration 08m 32s
Commit git commit af64522001: fix: migration session paths 404, email settings (#1296)
Committer Anna Hughes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 81
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant