Create a new GET /courses_user endpoint #720 #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kyleecodes, could you review this PR, please? |
csehatt741
force-pushed
the
csehatt741/courses_user-endpoint-#720
branch
from
b33fffc to
0bbaaf3
Compare
kyleecodes
reviewed
Jan 14, 2025
There was a problem hiding this comment.
LGTM so far. Confirmed all integration tests pass on my machine. Next, I'm testing the functionality of the new endpoint, then will merge ASAP.
Meanwhile @csehatt741 it would be helpful to provide screenshots verifying the functionality of your new GET /courses_user endpoint. Thanks!
|
|
kyleecodes
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
LGTM. Verified integration tests and functionality on my machine.
Thank you @csehatt741!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #720
What changes did you make and why did you make them?
CourseUserService.getCourseUserByUserIdreturn type to explicitly specify type informationCoursesUserControllerand exposed the newGET /courses_userendpoint to retrieve session and course data specifically for courses or session pagesCourseUserModuleDid you run tests? Share screenshot of results: