api: add chat_id to all call events
#7216
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
chat-id-for-call-events
branch
from
b808b65 to
9bc24c7
Compare
|
this is appreciated, sadly android use C events that are crappy and only provide message ID and payload and the message object needs to be loaded from the database just to get the chat id |
|
Which is to say that this is bad for performance? Ok, let's close then. |
|
why? what is bad for performance is providing only the msg ID and then the client needing to load the whole message object just to get the chat ID |
|
We can merge this if you are going to use it in desktop. |
|
Oh. I assumed that the comment was about this MR, that with this change the OK, let me finish this MR up then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.