feat: Synchronize encrypted groups creation across devices (#7001) #7009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
reviewed
Jul 19, 2025
iequidoo
force-pushed
the
iequidoo/sync_create_group
branch
2 times, most recently
from
af4c33a to
2530a6c
Compare
link2xt
reviewed
Jul 26, 2025
iequidoo
force-pushed
the
iequidoo/sync_create_group
branch
from
2530a6c to
e4fd633
Compare
iequidoo
force-pushed
the
iequidoo/sync_create_group
branch
from
e4fd633 to
fa5fda4
Compare
Hocuri
reviewed
Aug 27, 2025
|
Thanks for fixing! Once member addition&removal works, this LGTM |
iequidoo
force-pushed
the
iequidoo/sync_create_group
branch
2 times, most recently
from
ab25c68 to
55bb249
Compare
iequidoo
requested review from
link2xt and
Hocuri
and removed request for
link2xt
Hocuri
reviewed
Aug 28, 2025
iequidoo
force-pushed
the
iequidoo/sync_create_group
branch
from
55bb249 to
7904843
Compare
12 tasks
iequidoo
force-pushed
the
iequidoo/sync_create_group
branch
from
7904843 to
0fa0f14
Compare
Hocuri
approved these changes
Sep 12, 2025
There was a problem hiding this comment.
Nice!
But @link2xt said in #7111 (comment) to merge the PR here after #7116, so, merging this still has to wait a bit.
|
It's after #7116 not because of merge conflict, but because if we do this before removing protected groups, we need to synchronize whether the group is protected or not. So we first remove protected groups and then don't have to synchronize this status. |
Unencrypted groups don't have grpid since key-contacts were merged, so we don't sync them for now.
If we use modules (which are actually namespaces), we can use shorter names. Another approach is to only use modules for internal code incapsulation and use full names like deltachat-ffi does.
iequidoo
force-pushed
the
iequidoo/sync_create_group
branch
from
0fa0f14 to
be8d47a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7001
To be merged after #7116