Skip to content

docs: add missing documentation to deltachat-rpc-client #6846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented May 10, 2025

No description provided.

@link2xt link2xt requested a review from Hocuri May 10, 2025 16:56
Comment on lines 36 to 39
Note:

- does not delete messages on server
- the chat or contact is not blocked, new message will arrive

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this change? Won't it break markdown rendering?

Comment on lines 48 to 49
"""Get a multi-line encryption info, containing your fingerprint and
the fingerprint of the contact.
"""
"""Get a multi-line encryption info, containing your fingerprint and the fingerprint of the contact."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? The line seems pretty long now?

"""Return True-like value if the event passed the filter and should be
used, or False-like value otherwise.
"""
"""Return True-like value if the event passed the filter and should be used, or False-like value otherwise."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here, why put everything on one line?

@link2xt link2xt force-pushed the link2xt/rpc-client-docs branch from 0353a9c to c1471bd Compare May 12, 2025 17:39
@link2xt link2xt merged commit c1471bd into main May 12, 2025
29 checks passed
@link2xt link2xt deleted the link2xt/rpc-client-docs branch May 12, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants