[After UIs introduced a multi-tranpsort screen] api!: Remove unused config smtp_certificate_checks, deprecate old transport configs #6803
Conversation
Also, fix small bug that the configured server didn't turn up in get_info().
Hocuri
changed the title
Hocuri
changed the title
Hocuri
changed the title
| @@ -43,50 +43,84 @@ use crate::tools::get_abs_path; | |||
| )] | |||
| #[strum(serialize_all = "snake_case")] | |||
| pub enum Config { | |||
| /// Deprecated(2025-04). | |||
There was a problem hiding this comment.
Probably needs to be updated before merging
| @@ -406,7 +406,6 @@ char* dc_get_blobdir (const dc_context_t* context); | |||
| * - `proxy_enabled` = Proxy enabled. Disabled by default. | |||
| * - `proxy_url` = Proxy URL. May contain multiple URLs separated by newline, but only the first one is used. | |||
| * - `imap_certificate_checks` = how to check IMAP certificates, one of the @ref DC_CERTCK flags, defaults to #DC_CERTCK_AUTO (0) | |||
| * - `smtp_certificate_checks` = deprecated option, should be set to the same value as `imap_certificate_checks` but ignored by the new core | |||
There was a problem hiding this comment.
In deltachat.h there is mail_pw etc still around. mail_pw is even marked as "always needed".
There was a problem hiding this comment.
In deltachat.h there is mail_pw etc still around.
mail_pw etc. is still used in order for the UIs to query the entered login params. The UIs will switch to list_transports() when they implement a screen for listing and editing the transports. The reasoning for this is that UIs would have to do work twice, if they have to switch to `list_transports() now, and then later completely rework the account-login options, anyway.
mail_pwis even marked as "always needed".
We could change this, but I don't see what it has to do with the PR here? Though we will likely mark mail_pw etc. as deprecated or remove it in a few months from now, anyways, so, I don't think it's important right now.
There was a problem hiding this comment.
mail_pwetc. is still used in order for the UIs to query the entered login params.
Oops, wait, it's long since I opened the PR here, and when opening the PR here, I didn't know that we still want to use mail_pw etc. in the UI. I will mark the PR here as a draft, and revive it when we actually don't need these anymore.
Hocuri
changed the title
In preparation for mt, this deprecates the old configs Config::Addr, Config::MailPw, etc. which were used to pass login data to core
and the Config::Configured* configs which I replaced by the
transportstable.smtp_certificate_checkswas not used by anything, so I removed it instead of deprecating.Also, fix small bug that the configured server didn't turn up in get_info().
There are still some transport-related configs left, and we will need to discuss what to do about them:
transportstable