Bug/VENTokenView fixes #173
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add and delete users with the same name, set max token height, fix scrolling of tableview when keyboard showing, disable group name when adding users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some small bugs associated with the VENTokenView
View wouldn't resize properly when tokens were added (due to incorrect constraints)
View didn't allow users with duplicate names (due to adding and removing name instead of users from array)
TableView constraints not set properly meaning when keyboard was shown you couldn't scroll all users
Some logic added to ensure the group name is hidden when adding users to a group (we will modify user view to enable detail modification)