Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(labels): add option to prevent overlapping labels #1428

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

L-Har
Copy link

@L-Har L-Har commented Jun 4, 2024

Add an option to pie chart that can prevent overlapping labels. If preventOverlappingLabelOffset is Nonzero check if a label has overlapping text then move it the number of pixels up and left (Should be label size)

@L-Har
Copy link
Author

L-Har commented Jun 4, 2024

@evertheylen Would you mind taking a look at this pull request? I think this would be a useful option if it were to be added into the main branch.

@evertheylen
Copy link
Contributor

@L-Har the code looks good from a cursory glance but I'm not sure why you're asking me :)

@L-Har
Copy link
Author

L-Har commented Jun 4, 2024

@evertheylen Sorry about that, I thought you were a maintainer. Thanks for approving though

@L-Har
Copy link
Author

L-Har commented Jun 4, 2024

@gionkunz Would you mind reviewing this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants