Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SG - New place for wallet addresses #380

Merged
merged 12 commits into from
Oct 30, 2024
Merged

Conversation

valentinludu
Copy link
Contributor

This will be a 2 step migration.

After this PR is merged a script will move all addresses from walletAddress to ScoutWallet table.

Then we can delete walletAddress column and run the migration.

Copy link

github-actions bot commented Oct 28, 2024

Code e499503 labeled version 0.91.1-rc-feat-sg-wallet.1

Copy link

Copy link


model ScoutWallet {
id String @id @default(uuid()) @db.Uuid
createdAt DateTime @default(now())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea to store this

@@ -3166,3 +3167,11 @@ model BuilderCardActivity {

@@unique([builderId])
}

model ScoutWallet {
id String @id @default(uuid()) @db.Uuid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we don't even need an id?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I think it is not necessary. I removed id and added address as an index since we will search by address on login

Copy link

Copy link

Copy link

Copy link

Copy link

Copy link

@valentinludu valentinludu merged commit a49eb7f into main Oct 30, 2024
@valentinludu valentinludu deleted the feat/sg-wallet-addresses branch October 30, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants