Skip to content

Commit

Permalink
Add view evaluations permission (#376)
Browse files Browse the repository at this point in the history
* Add view evaluations permission

* ci: version bump to 0.88.7-rc-proposals-view.0

* Add proposal evaluation settings

* Bump core

* ci: version bump to 0.89.3-rc-proposals-view.0

* Fix migration

* ci: version bump to 0.89.3-rc-proposals-view.1

* Extend workflow evaluation json

* ci: version bump to 0.89.3-rc-proposals-view.2

* Remove unused prop

* ci: version bump to 0.89.3-rc-proposals-view.3

* Extend generator method

* ci: version bump to 0.89.3-rc-proposals-view.4

---------

Co-authored-by: Automated Version Bump <[email protected]>
  • Loading branch information
motechFR and Automated Version Bump authored Oct 25, 2024
1 parent afa9dcb commit 8ef3c3a
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@charmverse/core",
"version": "0.89.2",
"version": "0.89.3-rc-proposals-view.4",
"description": "Core API for Charmverse",
"type": "commonjs",
"types": "./dist/cjs/index.d.ts",
Expand Down
1 change: 1 addition & 0 deletions src/lib/proposals/interfaces.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export type WorkflowEvaluationJson = Pick<ProposalEvaluation, 'id' | 'title' | '
reject?: string;
} | null;
dueDate?: Date | null;
showAuthorResultsOnRubricFail?: boolean | null;
};

export type ProposalWorkflowTyped = Omit<ProposalWorkflow, 'evaluations'> & {
Expand Down
6 changes: 5 additions & 1 deletion src/lib/testing/proposals.ts
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,11 @@ export async function generateProposal({
appealable: input.appealable,
appealRequiredReviews: input.appealRequiredReviews,
finalStep: input.finalStep,
dueDate: input.dueDate
dueDate: input.dueDate,
showAuthorResultsOnRubricFail: input.showAuthorResultsOnRubricFail,
shareReviews: input.shareReviews,
actionLabels: input.actionLabels,
notificationLabels: input.notificationLabels
}) as Prisma.ProposalEvaluationCreateManyInput
),
skipDuplicates: true
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
-- AlterTable
ALTER TABLE "ProposalEvaluation" ADD COLUMN "showAuthorResultsOnRubricFail" BOOLEAN;
1 change: 1 addition & 0 deletions src/prisma/schema.prisma
Original file line number Diff line number Diff line change
Expand Up @@ -1383,6 +1383,7 @@ model ProposalEvaluation {
appealer User? @relation(fields: [appealedBy], references: [id], onDelete: SetNull, name: "appealedBy")
shareReviews Boolean? @default(false)
dueDate DateTime?
showAuthorResultsOnRubricFail Boolean?
rubricCriteria ProposalRubricCriteria[]
rubricAnswers ProposalRubricCriteriaAnswer[]
draftRubricAnswers DraftProposalRubricCriteriaAnswer[]
Expand Down

0 comments on commit 8ef3c3a

Please sign in to comment.