feat(wasm): Add empty functions for js builds to enable WASM builds#887
Open
BigJk wants to merge 3 commits into
Open
feat(wasm): Add empty functions for js builds to enable WASM builds#887BigJk wants to merge 3 commits into
BigJk wants to merge 3 commits into
Conversation
BigJk
changed the title
Contributor
|
Hi! Thanks so much for the PR! I believe this is a duplicate of #748 |
|
Can we move this forward by using a fork of the clipboard package? |
|
Hello! Can we move this forward? Thanks! |
aymanbagabas
requested review from
aymanbagabas and
meowgorithm
as code owners
|
Status ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello charm
ヾ(＾∇＾)In this write-up I laid out which changes would be needed to make bubbletea easily compile for WASM: https://github.com/BigJk/bubbletea-in-wasm
One of the changes would be to introduce some simple filler functions for js inside bubbletea so that a build with
GOOS=js GOARCH=wasmwon't break. These are contained in this pull request 😀 Additionally 2 dependencies needs to be bumped but I didn't include it into this PR atm as this depends on the response in atotto/clipboard#48I still opened the PR to track the progress and will gladly answer any questions!