Test gh app by charlieblevins · Pull Request #4 · charlieblevins/dukweb

charlieblevins · 2022-03-27T02:35:31Z

No description provided.

…tGHApp

charlieblevins · 2022-03-27T03:12:29Z

+
+  function validate_marker_post (fields, file, res) {
+
+    console.log('validating photo');


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

console.log('validating photo');

console.log("validating photo");

charlieblevins · 2022-03-27T03:12:30Z

+  initPassport(passport);
+
+  // Allow index router to handle all incoming requests
+  var routes = require('./routes/index')(passport);


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

var routes = require('./routes/index')(passport);

var routes = require("./routes/index")(passport);

charlieblevins · 2022-03-27T03:12:31Z

+          if (tags) {
+
+              // Update marker data
+              Marker.findOne({'_id': marker_id}, function (err, marker) {


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

Marker.findOne({'_id': marker_id}, function (err, marker) {

Marker.findOne({"_id": marker_id}, function (err, marker) {

charlieblevins · 2022-03-27T03:12:32Z

+          reads = [],
+          ids;
+
+          console.log('photo requests: ' + JSON.stringify(markers));


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

console.log('photo requests: ' + JSON.stringify(markers));

console.log("photo requests: " + JSON.stringify(markers));

charlieblevins · 2022-03-27T03:12:33Z

+    }
+
+    // respond with json
+    if (req.accepts('json')) {


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

if (req.accepts('json')) {

if (req.accepts("json")) {

charlieblevins · 2022-03-27T03:12:34Z

+      _ = require("underscore"),
+      fs = require('fs'),
+      formidable = require('formidable'),
+      crypto = require('crypto'),


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

crypto = require('crypto'),

crypto = require("crypto"),

charlieblevins · 2022-03-27T03:12:35Z

+              } else if (err.code === 11000) {
+                  return res.status(422).json({message: 'Image file already exists. Duplicate images are not allowed.'});
+              } else {
+                  return res.status(500).json({message: 'An internal error occurred'});


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

return res.status(500).json({message: 'An internal error occurred'});

return res.status(500).json({message: "An internal error occurred"});

charlieblevins · 2022-03-27T03:12:36Z

-            reads.push(read.promise);
+              console.log('err code: ' + err.code);
+              if (err.code === 16755) {
+                  return res.status(422).json({message: 'Latitude and longitude are not geographically valid.'});


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

return res.status(422).json({message: 'Latitude and longitude are not geographically valid.'});

return res.status(422).json({message: "Latitude and longitude are not geographically valid."});

charlieblevins · 2022-03-27T03:12:37Z

-        // Loop over each size for this marker
-        sizes.forEach((size) => {
+          if (err) {
+              console.log('Error in saving marker: ' + err);


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

console.log('Error in saving marker: ' + err);

console.log("Error in saving marker: " + err);

charlieblevins · 2022-03-27T03:12:38Z

+          console.log('photo requests: ' + JSON.stringify(markers));
+
+      if (!markers) {
+          console.log('invalid data for get_photo_b64');


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

console.log('invalid data for get_photo_b64');

console.log("invalid data for get_photo_b64");

charlieblevins · 2022-03-27T03:12:39Z

+
+                  // Make sure user is authorized to see/edit this marker
+                  if (!marker.user_id.equals(req.user._id)) {
+                      return res.status(403).json({message: 'You are not authorized to view this marker'});


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

return res.status(403).json({message: 'You are not authorized to view this marker'});

return res.status(403).json({message: "You are not authorized to view this marker"});

charlieblevins · 2022-03-27T03:12:40Z

+              if (page_index >= 0) {
+                  query.skip(page_index * res_per_page);
+              } else {
+                  console.log('invalid page value');


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

console.log('invalid page value');

console.log("invalid page value");

charlieblevins · 2022-03-27T03:12:40Z

+              ['', '_md', '_sm'].forEach((suffix) => {
+
+                  const photo = marker._id.toString() + suffix + '.jpg';
+                  const existing_path = __dirname + '/public/photos/' + photo;


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

const existing_path = __dirname + '/public/photos/' + photo;

const existing_path = __dirname + "/public/photos/" + photo;

charlieblevins · 2022-03-27T03:12:41Z

+  }
+
+  function handle_marker_data_failure () {
+      console.log('marker data failure');


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

console.log('marker data failure');

console.log("marker data failure");

charlieblevins added 5 commits March 26, 2022 21:59

this message does not begin with M

46084c2

M this message does begin with M

fbda039

Merge branch 'testGHApp' of github.com:charlieblevins/dukweb into tes…

8c62355

…tGHApp

testing codefactor

bca2a58

testing codefactor

fea3c68

charlieblevins commented Mar 27, 2022

View reviewed changes


		function validate_marker_post (fields, file, res) {

		console.log('validating photo');

	console.log('validating photo');
	console.log("validating photo");

	var routes = require('./routes/index')(passport);
	var routes = require("./routes/index")(passport);

	Marker.findOne({'_id': marker_id}, function (err, marker) {
	Marker.findOne({"_id": marker_id}, function (err, marker) {

	console.log('photo requests: ' + JSON.stringify(markers));
	console.log("photo requests: " + JSON.stringify(markers));

	return res.status(500).json({message: 'An internal error occurred'});
	return res.status(500).json({message: "An internal error occurred"});

	return res.status(422).json({message: 'Latitude and longitude are not geographically valid.'});
	return res.status(422).json({message: "Latitude and longitude are not geographically valid."});

	console.log('Error in saving marker: ' + err);
	console.log("Error in saving marker: " + err);

	console.log('invalid data for get_photo_b64');
	console.log("invalid data for get_photo_b64");

	return res.status(403).json({message: 'You are not authorized to view this marker'});
	return res.status(403).json({message: "You are not authorized to view this marker"});

	console.log('invalid page value');
	console.log("invalid page value");

	const existing_path = __dirname + '/public/photos/' + photo;
	const existing_path = __dirname + "/public/photos/" + photo;

	console.log('marker data failure');
	console.log("marker data failure");

Conversation

charlieblevins commented Mar 27, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant