CbChargeSOMDriver: fix reporting of BSP event when no contactor is configured#52
Open
CbChargeSOMDriver: fix reporting of BSP event when no contactor is configured#52
Conversation
lategoodbye
reviewed
Feb 5, 2026
mhei
force-pushed
the
bugfix/cbchargesom-poweronoff-event
branch
from
57d1bbb to
886683f
Compare
lategoodbye
reviewed
Feb 6, 2026
modules/CbChargeSOMDriver/evse_board_support/evse_board_supportImpl.cpp
Outdated
Show resolved
Hide resolved
modules/CbChargeSOMDriver/evse_board_support/evse_board_supportImpl.cpp
Outdated
Show resolved
Hide resolved
…nfigured In this case, we cannot rely on the contactor flags in the Charge Control message. In other words, we dont have a trigger then and must create the events ourself. Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
mhei
force-pushed
the
bugfix/cbchargesom-poweronoff-event
branch
from
886683f to
43a5171
Compare
lategoodbye
approved these changes
Feb 6, 2026
Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this case, we cannot rely on the flags in the Charge Control message. In other words, we dont have a trigger then and must create the events ourself.