Extend Troubleshooting & CAN documentation#81
Merged
lategoodbye merged 4 commits intoeverest/charge_somfrom Dec 15, 2025
Merged
Extend Troubleshooting & CAN documentation#81lategoodbye merged 4 commits intoeverest/charge_somfrom
lategoodbye merged 4 commits intoeverest/charge_somfrom
Conversation
Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
mhei
requested changes
Dec 12, 2025
Member
mhei
left a comment
mhei
left a comment
There was a problem hiding this comment.
I suggest the following changes:
- I usually prefer to capitalize some words in the headings (see "Chicago Manual of Style" at https://en.wikipedia.org/wiki/Title_case)
- after reconsidering, I think a less-invasive configuration approach might/should be used:
mkdir /etc/systemd/network/can0.network.d
cat <<EOF > /etc/systemd/network/can0.network.d/bitrate.conf
[CAN]
BitRate=125000
EOF
- you've written "persistent", maybe we extend and explain it that this means that this is kept over reboot and over firmware update and that the following commands are only necessary to apply the settings immediately without reboot
Member
Author
|
I addressed the comments. |
Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
lategoodbye
force-pushed
the
everest/charge_som_trouble
branch
from
25e4bbb to
63b8e48
Compare
barsnick
approved these changes
Dec 15, 2025
mhei
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request extend the FAQ chapter and the CAN documentation.
Documentation of CAN dump handling is considered as part of development, which is part of the includes and a separate pull request.