[ui] Show more information when reviewing recommendations #953
+1,190
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sduenas
requested changes
Feb 26, 2025
Adds the Font Awesome icons set, which includes icons for Confluence, Jenkins, Phabricator and Meetup. To use them in the VIcon component, their name must be prefaced by 'fa:'. It also adds an svg icon for Gerrit. Signed-off-by: Eva Millán <[email protected]>
Adds a 'detailed' prop to the IndividualCard component, which shows a list of usernames and email addresses instead of only the source icons, to be used on recommendations. Signed-off-by: Eva Millán <[email protected]>
evamillan
force-pushed
the
improve-ui-recommendations
branch
from
255d0a4 to
a9c3399
Compare
|
Thanks @sduenas, I added the changelog file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a list of the individual's usernames and email addresses to the cards in the "Review recommendations" modal to compare them more easily. It also adds more source icons to avoid grouping many of them into "other sources".
Fixes #952, #936