Skip to content

Commit

Permalink
Merge pull request #2667 from chaoss/fix-collection-issue
Browse files Browse the repository at this point in the history
Fix a few small collection issues
  • Loading branch information
ABrain7710 authored Jan 23, 2024
2 parents e3e9a61 + 80d0c9d commit 1c94076
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
3 changes: 2 additions & 1 deletion augur/tasks/github/messages/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,8 @@ def process_messages(messages, task_name, repo_id, logger, augur_db):
message_string_fields = ["msg_text"]
message_return_data = augur_db.insert_data(message_dicts, Message, message_natural_keys,
return_columns=message_return_columns, string_fields=message_string_fields)

if message_return_data is None:
return

pr_message_ref_dicts = []
issue_message_ref_dicts = []
Expand Down
3 changes: 2 additions & 1 deletion augur/tasks/github/releases/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ def insert_release(augur_db, logger, repo_id, owner, release, tag_only = False):
release_inf = get_release_inf(repo_id, release, tag_only)

#Do an upsert
augur_db.insert_data(release_inf,Release,['release_id'])
string_fields = ["release_name", "release_description", "release_author", "release_tag_name"]
augur_db.insert_data(release_inf,Release,['release_id'], string_fields=string_fields)

logger.info(f"Inserted info for {owner}/{repo_id}/{release['name']}\n")

Expand Down
2 changes: 1 addition & 1 deletion augur/tasks/util/worker_util.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def parse_json_from_subprocess_call(logger, subprocess_arr, cwd=None):
try:
required_output = json.loads(output)
except json.decoder.JSONDecodeError as e:
session.logger.error(f"Could not parse required output! \n output: {output} \n Error: {e}")
logger.error(f"Could not parse required output! \n output: {output} \n Error: {e}")
raise e

return required_output
Expand Down

0 comments on commit 1c94076

Please sign in to comment.