Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointer::last return None for root pointer #23

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

wngr
Copy link

@wngr wngr commented Mar 4, 2024

Hey again,

just hit this one: Pointer::last panics for empty/root pointers.

Added the root check as was already done for Pointer::front.

Cheers!

@chanced chanced merged commit c17a55d into chanced:main Mar 4, 2024
1 check passed
@chanced
Copy link
Owner

chanced commented Mar 4, 2024

Awesome, thanks. Also, sorry about that.

@chanced chanced mentioned this pull request Mar 4, 2024
@chanced
Copy link
Owner

chanced commented Mar 4, 2024

v0.4.6 was published with this.

@wngr
Copy link
Author

wngr commented Mar 5, 2024

Awesome, thanks. Also, sorry about that.

No need to be sorry about anything! You created a nice library with jsonptr, and some things just surface when actually using it.

Thanks for being so responsive!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants