-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Ares-6 #4856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ares-6 #4856
Conversation
4608729
to
3e0a7ae
Compare
You must also update https://github.com/Microsoft/ChakraCore/blob/master/THIRD-PARTY-NOTICES.txt to include the license notice of the benchmark |
@Cellule thanks, updated |
this.averageWorstCase.add((steadyTimes[0] + steadyTimes[1] + steadyTimes[2] + steadyTimes[3]) / 4); | ||
this.steadyState.add(steadyTimes.reduce((previous, current) => previous + current) / steadyTimes.length); | ||
this.reportDone(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Cellule This prints the benchmark's results, from https://browserbench.org/ARES-6/about.html their results is not a single score, but they use 1. time for first iteration, 2. avg time for first 4 iterations and 3. avg time for all but first iteration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; note that you may want to add this to the perftester xml for ease of internal runs.
Merge pull request #4856 from meg-gupta:addares6 Adding all the files required to run the cli version of Ares-6. The benchmark can be run from cli.js
Adding all the files required to run the cli version of Ares-6.
The benchmark can be run from cli.js