Skip to content

Add Ares-6 #4856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 7, 2018
Merged

Add Ares-6 #4856

merged 6 commits into from
May 7, 2018

Conversation

meg-gupta
Copy link
Contributor

@meg-gupta meg-gupta commented Mar 22, 2018

Adding all the files required to run the cli version of Ares-6.
The benchmark can be run from cli.js

@Cellule
Copy link
Contributor

Cellule commented Apr 13, 2018

You must also update https://github.com/Microsoft/ChakraCore/blob/master/THIRD-PARTY-NOTICES.txt to include the license notice of the benchmark

@meg-gupta
Copy link
Contributor Author

@Cellule thanks, updated

@Cellule
Copy link
Contributor

Cellule commented Apr 14, 2018

Maybe we should print SCORE: <time> ms to be more consistent with what some other benchmarks do


Refers to: test/benchmarks/ARES-6/Basic/test.js:17 in 55f37c8. [](commit_id = 55f37c8, deletion_comment = False)

this.averageWorstCase.add((steadyTimes[0] + steadyTimes[1] + steadyTimes[2] + steadyTimes[3]) / 4);
this.steadyState.add(steadyTimes.reduce((previous, current) => previous + current) / steadyTimes.length);
this.reportDone();
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cellule This prints the benchmark's results, from https://browserbench.org/ARES-6/about.html their results is not a single score, but they use 1. time for first iteration, 2. avg time for first 4 iterations and 3. avg time for all but first iteration.

Copy link
Contributor

@Penguinwizzard Penguinwizzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; note that you may want to add this to the perftester xml for ease of internal runs.

@chakrabot chakrabot merged commit 319c514 into chakra-core:master May 7, 2018
chakrabot pushed a commit that referenced this pull request May 7, 2018
Merge pull request #4856 from meg-gupta:addares6

Adding all the files required to run the cli version of Ares-6.
The benchmark can be run from cli.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants