Skip to content

feat: Stop at height fullnode argument#3165

Open
jfldde wants to merge 9 commits intonightlyfrom
feat/stop-at-height
Open

feat: Stop at height fullnode argument#3165
jfldde wants to merge 9 commits intonightlyfrom
feat/stop-at-height

Conversation

@jfldde
Copy link
Contributor

@jfldde jfldde commented Feb 26, 2026

Description

  • Hidden args to stop the node at a target L1/L2 height

Linked Issues

@jfldde jfldde requested a review from a team as a code owner February 26, 2026 12:18
@auto-assign auto-assign bot requested a review from ercecan February 26, 2026 12:18
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.5%. Comparing base (a030fa8) to head (5988547).
⚠️ Report is 1 commits behind head on nightly.

Files with missing lines Patch % Lines
crates/fullnode/src/da_block_handler.rs 66.6% 2 Missing ⚠️
bin/citrea/src/main.rs 83.3% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
bin/citrea/src/cli.rs 77.2% <ø> (ø)
bin/citrea/src/rollup/mod.rs 86.4% <100.0%> (+<0.1%) ⬆️
crates/common/src/utils.rs 82.4% <100.0%> (+0.4%) ⬆️
crates/ethereum-rpc/src/subscription.rs 84.9% <100.0%> (ø)
crates/fullnode/src/l2_syncer.rs 100.0% <100.0%> (ø)
crates/fullnode/src/lib.rs 97.1% <100.0%> (+0.1%) ⬆️
bin/citrea/src/main.rs 79.3% <83.3%> (-1.2%) ⬇️
crates/fullnode/src/da_block_handler.rs 85.9% <66.6%> (-0.3%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ercecan
ercecan previously approved these changes Feb 27, 2026
ercecan
ercecan previously approved these changes Mar 2, 2026
@jfldde jfldde mentioned this pull request Mar 2, 2026
eyusufatik
eyusufatik previously approved these changes Mar 6, 2026
@jfldde jfldde dismissed stale reviews from eyusufatik and ercecan via b25c59b March 10, 2026 08:01
exeokan
exeokan previously approved these changes Mar 10, 2026
@jfldde jfldde requested a review from exeokan March 10, 2026 12:01
jfldde added a commit that referenced this pull request Mar 10, 2026
# Description

- Script used for diffing rocksdb post upgrade.
- Used for ensuring #2983 upgrade doesn't introduce any regression
- Will be used in conjunction with #3165 to stop at L1/L2 height, stop
both nodes, and run this script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to sync up and stop at a certain height

4 participants