ruby: add pipeline to install the gemspec defined runtime deps #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hector Fernandez <[email protected]>
Signed-off-by: Hector Fernandez <[email protected]>
hectorj2f
force-pushed
the
ruby_install_runtime_deps
branch
from
93b2801 to
aeabaaa
Compare
Signed-off-by: Hector Fernandez <[email protected]>
hectorj2f
force-pushed
the
ruby_install_runtime_deps
branch
2 times, most recently
from
35b6662 to
9325060
Compare
Signed-off-by: Hector Fernandez <[email protected]>
hectorj2f
force-pushed
the
ruby_install_runtime_deps
branch
from
9325060 to
2021562
Compare
|
I am pretty sure we don't want to do this, as this will result in Gems being vendored. Instead, melange convert should be used to generate a forest of dependencies. |
|
@kaniini Okay. I'll have a look at 'melange convert' to understand how it could help us here. |
|
Closing this PR! I'll use melange instead to vendor all the runtime deps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Melange Pull Request Template
Fixes #785. This pipeline installs the gem runtime dependencies that are required by a specific ruby project.
Functional Changes
Notes:
SCA Changes
Notes:
Linter
Notes: